<html>
<body>
  <div id="body" style="background-color:#ffffff;" >
<table cellspacing="0" cellpadding="0" border="0" rules="cols">
<tr class="head" style="border-bottom-width:1px;border-bottom-style:solid;" ><td class="headtd" style="padding:0;padding-top:.2em;" colspan="4">Commit in <b><tt>lxdream/src</tt></b></td></tr>
<tr><td><tt>drivers/<a href="#file1">cd_mmc.c</a></tt></td><td id="added" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ddffdd;" align="right">+2</td><td id="removed" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ffdddd;" align="right">-2</td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr class="alt" style=";" ><td><tt>       /<a href="#file2">net_osx.m</a></tt></td><td id="addedalt" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ccf7cc;" align="right">+2</td><td></td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr><td><tt><a href="#file3">gdbserver.c</a></tt></td><td id="added" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ddffdd;" align="right">+3</td><td id="removed" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ffdddd;" align="right">-2</td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr class="alt" style=";" ><td><tt>gdrom/<a href="#file4">gdimage.c</a></tt></td><td id="addedalt" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ccf7cc;" align="right">+1</td><td></td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr><td><tt><a href="#file5">plugin.c</a></tt></td><td id="added" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ddffdd;" align="right">+1</td><td id="removed" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ffdddd;" align="right">-1</td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr class="alt" style=";" ><td><tt>sh4/<a href="#file6">sh4.c</a></tt></td><td id="addedalt" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ccf7cc;" align="right">+1</td><td></td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr><td><tt>vmu/<a href="#file7">vmulist.c</a></tt></td><td id="added" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ddffdd;" align="right">+3</td><td id="removed" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ffdddd;" align="right">-2</td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr class="alt" style=";" ><td><tt>   /<a href="#file8">vmuvol.c</a></tt></td><td id="addedalt" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ccf7cc;" align="right">+3</td><td id="removed" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ffdddd;" align="right">-1</td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr><td><tt>xlat/x86/<a href="#file9">x86op.h</a></tt></td><td id="added" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ddffdd;" align="right">+2</td><td id="removed" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ffdddd;" align="right">-2</td><td class="headtd2" style="padding-left:.3em;padding-right:.3em;" nowrap="nowrap">f543ee84dceb -> 182cfe43c09e</td></tr>
<tr><td></td><td id="added" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ddffdd;" align="right">+18</td><td id="removed" class="headtd2" style="padding-left:.3em;padding-right:.3em; background-color:#ffdddd;" align="right">-10</td><td></td></tr>
</table>
<small id="info" style="color: #888888;" >9 modified files</small><br />
<pre class="comment" style="white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;white-space:pre-wrap;word-wrap:break-word;padding:4px;border:1px dashed #000000;background-color:#ffffdd;" >
Fix assorted -Wall warnings
</pre>
<hr /><a name="file1" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src/drivers</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>cd_mmc.c</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/drivers/cd_mmc.c
+++ lxdream/src/drivers/cd_mmc.c
@@ -175,7 +175,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     if( status == PKT_ERR_OK ) {
            mmc_parse_toc2( disc, buf );        
     } else {
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-           if( status & 0xFF != 0x02 ) {
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+     if( (status & 0xFF) != 0x02 ) {
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >                /* Sense key 2 == Not Ready (ie temporary failure). Just ignore and
             * consider the drive empty for now, but warn about any other errors
             * we get. */
</pre><pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >@@ -239,4 +239,4 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >      gdrom_scsi_read_toc(disc);
     }
     return disc;
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-} 
</pre><pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >\ No newline at end of file
</small></pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+} 
</pre></div>
<hr /><a name="file2" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src/drivers</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>net_osx.m</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/drivers/net_osx.m
+++ lxdream/src/drivers/net_osx.m
@@ -73,4 +73,6 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >             net_osx_callback, &socketContext );
     cbinfo->sourceRef = CFSocketCreateRunLoopSource( kCFAllocatorDefault, cbinfo->sockRef, 0 );
     CFRunLoopAddSource( CFRunLoopGetCurrent(), cbinfo->sourceRef, kCFRunLoopCommonModes );
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+
+    return TRUE;
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > }
</pre></div>
<hr /><a name="file3" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>gdbserver.c</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/gdbserver.c
+++ lxdream/src/gdbserver.c
@@ -523,6 +523,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     server->cpu = cpu;
     server->mmu = mmu;
     server->fd = fd;
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-    net_register_tcp_listener( fd, gdb_server_connect_callback, server, gdb_server_free );
-    INFO( "%s GDB server running on port %d", cpu->name, port ); 
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+    gboolean result = net_register_tcp_listener( fd, gdb_server_connect_callback, server, gdb_server_free );
+    INFO( "%s GDB server running on port %d", cpu->name, port );
+    return result;
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > }
</pre></div>
<hr /><a name="file4" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src/gdrom</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>gdimage.c</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/gdrom/gdimage.c
+++ lxdream/src/gdrom/gdimage.c
@@ -114,6 +114,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >          disc->play_audio = NULL; /* not supported yet */
            disc->run_time_slice = NULL; /* not needed */
        }
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+     return disc;
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > }
 
 
</pre></div>
<hr /><a name="file5" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>plugin.c</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/plugin.c
+++ lxdream/src/plugin.c
@@ -123,7 +123,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >  */
 static int plugin_load_all( const gchar *plugin_dir )
 {
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-    int plugin_count;
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+    int plugin_count<span id="addedchars" style="background-color:#99ff99;font-weight:bolder;" > = 0</span>;
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     struct dirent *ent;
     
     DIR *dir = opendir(plugin_dir);
</pre></div>
<hr /><a name="file6" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src/sh4</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>sh4.c</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/sh4/sh4.c
+++ lxdream/src/sh4/sh4.c
@@ -707,6 +707,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >             read_len += next_len; 
             length -= next_len;
         }
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+        return read_len;
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     } else {
         return sh4_debug_write_phys( addr, buf, length );
     }
</pre></div>
<hr /><a name="file7" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src/vmu</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>vmulist.c</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/vmu/vmulist.c
+++ lxdream/src/vmu/vmulist.c
@@ -131,6 +131,9 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >         entry->filename = g_strdup(filename);
         entry->vol = vol;
         vmu_list = g_list_insert_sorted(vmu_list, entry, vmulist_display_name_compare );
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+        vmulist_update_config();
+
+        CALL_HOOKS( vmulist_change_hook, VMU_ADDED, g_list_index(vmu_list,entry) );
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     } else {
         if( entry->vol != vol && entry->vol != NULL )
             vmu_volume_destroy( entry->vol );
</pre><pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >@@ -141,8 +144,6 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     }
     entry->attach_count = 0;
     
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-    vmulist_update_config();
-    CALL_HOOKS( vmulist_change_hook, VMU_ADDED, g_list_index(vmu_list,entry) );
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     return entry;
 }
 
</pre></div>
<hr /><a name="file8" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src/vmu</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>vmuvol.c</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/vmu/vmuvol.c
+++ lxdream/src/vmu/vmuvol.c
@@ -82,7 +82,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > #define FAT_EMPTY 0xFFFC
 #define FAT_EOF   0xFFFA
 
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-static const struct vmu_volume_metadata default_metadata = { 255, 255, 254, 1, 253, 13, 0, 200, <span id="removedchars" style="background-color:#ff9999;font-weight:bolder;" >31, 0, 128</span> };
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+static const struct vmu_volume_metadata default_metadata = { 255, 255, 254, 1, 253, 13, 0, 200, <span id="addedchars" style="background-color:#99ff99;font-weight:bolder;" >{31, 0, 128}</span> };
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > 
 vmu_volume_t vmu_volume_new_default( const gchar *display_name )
 {
</pre><pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >@@ -374,6 +374,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     }
     memcpy( VMU_BLOCK(vol,pt,block), in, VMU_BLOCK_SIZE );
     vol->dirty = TRUE;
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+    return TRUE;
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > }
 
 gboolean vmu_volume_write_phase( vmu_volume_t vol, vmu_partnum_t pt, unsigned int block, unsigned int phase, unsigned char *in )
</pre><pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >@@ -383,6 +384,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >     }
     memcpy( VMU_BLOCK(vol,pt,block) + (phase*128), in, VMU_BLOCK_SIZE/4 );
     vol->dirty = TRUE;
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+    return TRUE;
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > }
 
 const struct vmu_volume_metadata *vmu_volume_get_metadata( vmu_volume_t vol, vmu_partnum_t partition )
</pre></div>
<hr /><a name="file9" /><div class="file" style="border:1px solid #eeeeee;margin-top:1em;margin-bottom:1em;" >
<span class="pathname" style="font-family:monospace; float:right;" >lxdream/src/xlat/x86</span><br />
<div class="fileheader" style="margin-bottom:.5em;" ><big><b>x86op.h</b></big> <small id="info" style="color: #888888;" >f543ee84dceb -> 182cfe43c09e</small></div>
<pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >--- lxdream/src/xlat/x86/x86op.h
+++ lxdream/src/xlat/x86/x86op.h
@@ -146,7 +146,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > #define OPPTR(x) *((void **)xlat_output) = ((void *)x); xlat_output+=(sizeof(void*))
 
 /* Primary opcode emitter, eg OPCODE(0x0FBE) for MOVSX */
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-#define OPCODE(x) if( (x) > 0xFFFF ) { OP(x>>16); OP((x>>8)&0xFF); OP(x&0xFF); } else if( (x) > 0xFF ) { OP(x>>8); OP(x&0xFF); } else { OP(x); }
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+#define OPCODE(x) if( (x) > 0xFFFF ) { OP((x)>>16); OP(((x)>>8)&0xFF); OP((x)&0xFF); } else if( (x) > 0xFF ) { OP((x)>>8); OP((x)&0xFF); } else { OP(x); }
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > 
 /* Test if immediate value is representable as a signed 8-bit integer */
 #define IS_INT8(imm) ((imm) >= INT8_MIN && (imm) <= INT8_MAX)
</pre><pre class="diff" style="margin:0;" ><small id="info" style="color: #888888;" >@@ -174,7 +174,7 @@
</small></pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" >  * @param rr reg field 
  * @param rb r/m field
  */
</pre><pre id="removed" class="diff" style="margin:0; background-color:#ffdddd;" >-static <span id="removedchars" style="background-color:#ff9999;font-weight:bolder;" >int</span> x86_encode_reg_rm( int rexw, uint32_t opcode, int rr, int rb )
</pre><pre id="added" class="diff" style="margin:0; background-color:#ddffdd;" >+static <span id="addedchars" style="background-color:#99ff99;font-weight:bolder;" >void</span> x86_encode_reg_rm( int rexw, uint32_t opcode, int rr, int rb )
</pre><pre id="context" class="diff" style="margin:0; background-color:#eeeeee;" > {
     int rex = rexw;
     rr &= 0x0F;
</pre></div>
<center><small>Chaos Theory</small></center>
</div></body></html>